umeca74-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org [wtl]
2014-10-19 15:49:09 UTC
Here are some comments on the atlribbon.h implementation. In general it is a great piece of work but there are a few bits and bobs left to make it perfect!
1. ShowRibbonUI should take into account any REGULAR menu that the ribbon hid and restore it after the menu is re-enabled. The current implementation only works with a rebar/commandbar
2. ShowRibbonUI should take a parameter NOT to hide the toolbar (e.g. I have an addressbar that I want to keep alongside the ribbon). This can be handled in UpdateLayout by converting the toolbar/rebar into CCS_NOPARENTALIGN and manually positioning it below the ribbon.
3. m_bWin7Fix is a nasty workaround that unfortunately cannot be avoided (I've been trying for a couple of days but I gave up :). However the code should also be patched for windows 8; all the checks for IsWin7() should be converted to IsWin7OrLater() otherwise there will be problems in win8
I hope Alain Rist is reading :)
Nikos
1. ShowRibbonUI should take into account any REGULAR menu that the ribbon hid and restore it after the menu is re-enabled. The current implementation only works with a rebar/commandbar
2. ShowRibbonUI should take a parameter NOT to hide the toolbar (e.g. I have an addressbar that I want to keep alongside the ribbon). This can be handled in UpdateLayout by converting the toolbar/rebar into CCS_NOPARENTALIGN and manually positioning it below the ribbon.
3. m_bWin7Fix is a nasty workaround that unfortunately cannot be avoided (I've been trying for a couple of days but I gave up :). However the code should also be patched for windows 8; all the checks for IsWin7() should be converted to IsWin7OrLater() otherwise there will be problems in win8
I hope Alain Rist is reading :)
Nikos